feat(pyth-sui-js): Migrate from price-service-client to hermes-client #3120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
aditya520
approved these changes
Oct 13, 2025
ali-behjati
reviewed
Oct 14, 2025
| // Fetch the latest price feed update VAAs from the price service | ||
| const latestVaas = await this.getLatestVaas(priceIds); | ||
| return latestVaas.map((vaa) => Buffer.from(vaa, "base64")); | ||
| const latestVaas: PriceUpdate = await this.getLatestPriceUpdates(priceIds, { encoding: "base64", parsed: false }); |
There was a problem hiding this comment.
let's call this update data instead of Vaas (they are not vaas anymore)
ali-behjati
reviewed
Oct 14, 2025
ali-behjati
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate to hermes client to get pyth prices.
Rationale
price-service-client and associated endpoints are deprecated.
How has this been tested?